sdedic commented on issue #1039: [NETBEANS-1743] Ignores NbLifecycleManager exit call while already ex… URL: https://github.com/apache/incubator-netbeans/pull/1039#issuecomment-444105088 @emilianbold I see you're trying to break a deadlock when a `ModuleInstall` calls back to the system. What if the the special handling would apply to just the length of execution of `ModuleInstall.closing` called from `ModuleManager` ? I.e. some thread-local would help. Not ideal as it does not prevent exits called from async tasks waited on. WARN log is a good idea anyway. Instead of return, the exit() could throw some nasty kind of exception that would cut through caller's code and gets caught in the `NbInstaller` loop: it will return a sort of, but unless the caller does some error handling it will break out of the code more cleanly than a `return` that is not documented.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
