JaroslavTulach commented on a change in pull request #1011: Enhanced wrapper
for Scripting API
URL:
https://github.com/apache/incubator-netbeans/pull/1011#discussion_r239101249
##########
File path:
java/java.source.base/src/org/netbeans/api/java/source/GeneratorUtilities.java
##########
@@ -2212,8 +2209,7 @@ private static ScriptEngine engine(FileObject fo) {
if (obj instanceof String) {
synchronized (GeneratorUtilities.class) {
if (manager == null) {
- ClassLoader loader =
Lookup.getDefault().lookup(ClassLoader.class);
- manager = new ScriptEngineManager(loader != null ? loader
: Thread.currentThread().getContextClassLoader());
+ manager = Scripting.createManager();
Review comment:
The classloader logic is handled centrally in `Scripting.createManager()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
