eirikbakke commented on issue #1060: [NETBEANS-731] Making the test class a 
JUnit test
URL: 
https://github.com/apache/incubator-netbeans/pull/1060#issuecomment-450498358
 
 
   OK, I managed to trigger the error with "ant 
-Dtest-unit-sys-prop.ignore.random.failures=true test" run from the 
core.windows package only. Sorry I didn't catch this before! I was trying to 
run tests from the root NetBeans repo before, but got a lot of unrelated errors 
on even on a clean checkout, so I didn't have an effective way to pick out the 
error caused specifically by my own patch.
   
   Renaming "AutoHidingMenuBarManualTest" to 
"AutoHidingMenuBarManualTestAppError" fixes the error.
   
   On a side note, it would be lovely if we could make GitHub pull requests 
show errors when there are problems like these. At the moment it says "All 
checks have passed" as long as a test-less build passes, giving a false 
impression that PRs can be merged without breaking the build:
   
   
![allcheckspassed](https://user-images.githubusercontent.com/886243/50539535-28392b00-0b82-11e9-808c-8fafbae91947.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to