matthiasblaesing commented on issue #1082: [NETBEANS-1613] Fix for 'Select in 
Project' having no effect in JavaSE Modular Projects
URL: 
https://github.com/apache/incubator-netbeans/pull/1082#issuecomment-455800421
 
 
   The fix works, it is minimally invasive and if a better solution is found, 
can be easily removed. Build is clean, so merging this.
   
   Please note: I'll let github squash this (reducing it to one commit), as 
this matches what you intended.
   
   For the future, this might be interesting to you: 
https://git-scm.com/book/de/v1/Git-Branching-Rebasing rebasing can result in 
cleaner PR (at the price of history rewriting), not everyone likes it, so take 
it with a grain of salt.
   
   Thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to