JaroslavTulach commented on a change in pull request #1092: Using Scripting API
in platform/core.network
URL:
https://github.com/apache/incubator-netbeans/pull/1092#discussion_r249407448
##########
File path:
platform/core.network/src/org/netbeans/core/network/proxy/pac/impl/NbPacScriptEvaluator.java
##########
@@ -274,12 +271,7 @@ public String getPacScriptSource() {
private PacScriptEngine getScriptEngine(String pacSource) throws
PacParsingException {
try {
- ScriptEngine engine;
- if (nashornJava8u40Available) {
- engine = getNashornJSScriptEngine();
- } else {
- engine = getGenericJSScriptEngine();
- }
+ ScriptEngine engine = getGenericJSScriptEngine();
Review comment:
We don't want to prefer Nashorn. Removing the special casing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
