lbruun commented on a change in pull request #1092: Using Scripting API in
platform/core.network
URL:
https://github.com/apache/incubator-netbeans/pull/1092#discussion_r249551435
##########
File path:
platform/core.network/src/org/netbeans/core/network/proxy/pac/impl/NbPacScriptEvaluator.java
##########
@@ -384,29 +400,14 @@ private PacJsEntryFunction testScriptEngine(ScriptEngine
eng, boolean doDeepTest
}
private boolean isJsFunctionAvailable(ScriptEngine eng, String
functionName, boolean doDeepTest) {
- // We want to test if the function is there, but without actually
- // invoking it.
Review comment:
Consider keeping this comment as it explains the purpose of the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
