JaroslavTulach commented on a change in pull request #1091: [NETBEANS-1965]
Export public & friend packages for Payara Plugin
URL:
https://github.com/apache/incubator-netbeans/pull/1091#discussion_r249635354
##########
File path: enterprise/j2ee.sun.ddui/nbproject/project.xml
##########
@@ -368,10 +368,21 @@
</test-dependencies>
<friend-packages>
<friend>org.netbeans.modules.glassfish.javaee</friend>
+ <friend>org.netbeans.modules.payara.javaee</friend>
+ <friend>org.netbeans.modules.payara.eecommon</friend>
<friend>org.netbeans.modules.j2ee.sun.appsrv81</friend>
<friend>org.netbeans.modules.j2ee.sun.appsrv90</friend>
<friend>org.netbeans.modules.j2ee.sun.avk</friend>
<friend>org.netbeans.modules.j2ee.sun.ws7</friend>
+ <package>org.netbeans.modules.j2ee.sun.ddloaders</package>
+ <package>org.netbeans.modules.j2ee.sun.ddloaders.api</package>
+
<package>org.netbeans.modules.j2ee.sun.ddloaders.multiview</package>
+
<package>org.netbeans.modules.j2ee.sun.ddloaders.multiview.appclient</package>
+
<package>org.netbeans.modules.j2ee.sun.ddloaders.multiview.common</package>
+
<package>org.netbeans.modules.j2ee.sun.ddloaders.multiview.ejb</package>
+
<package>org.netbeans.modules.j2ee.sun.ddloaders.multiview.jms</package>
+
<package>org.netbeans.modules.j2ee.sun.ddloaders.multiview.web</package>
+
<package>org.netbeans.modules.j2ee.sun.ddloaders.multiview.webservice</package>
Review comment:
Very suspicious. Why nobody needed these packages yet? There is something
fishy in the code you write.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
