jtulach commented on a change in pull request #1095: [NETBEANS-1979] Allow
Modes to be created programatically.
URL:
https://github.com/apache/incubator-netbeans/pull/1095#discussion_r250453389
##########
File path:
platform/openide.windows/test/unit/src/org/openide/windows/OnShowingTest.java
##########
@@ -189,6 +189,21 @@ protected String topComponentID(TopComponent tc, String
preferredID) {
public TopComponent findTopComponent(String tcID) {
throw new UnsupportedOperationException("Not supported
yet.");
}
+
+ @Override
+ public void createModeFromXml(String xml) {
Review comment:
A change in test is great! But:
- first of all it signals why your change is incompatible - when you have to
update existing the tests, you are doing an incompatible change
- there should be real test showing how to use the new methods that you are
introducing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
