jlahoda commented on a change in pull request #1079: [NETBEANS-1780]:Fixed 
formatting issue in Switch Expression(JDK-12)
URL: 
https://github.com/apache/incubator-netbeans/pull/1079#discussion_r252136396
 
 

 ##########
 File path: 
java/java.source.base/src/org/netbeans/modules/java/source/save/Reformatter.java
 ##########
 @@ -2649,6 +2650,96 @@ public Boolean visitSwitch(SwitchTree node, Void p) {
             return true;
         }
 
+        public Boolean scanSwitchExpression(Tree node, Void p) {
 
 Review comment:
   I assume this is basically a copy of visitSwitch - was there an attempt to 
not duplicate the code? Not sure if that'd be possible, but maybe something 
like:
   handleSwitch(ExpressionTree expression, Iterable<? extends CaseTree> cases) 
{...}
   that would be called from both places?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to