matthiasblaesing commented on a change in pull request #1108: Upgraded ASM
libraries to 7.0
URL:
https://github.com/apache/incubator-netbeans/pull/1108#discussion_r252419026
##########
File path: nbbuild/templates/common.xml
##########
@@ -78,10 +78,10 @@
<tstamp>
<format property="module.build.started.time"
pattern="yyyy-MM-dd'T'HH:mm:ss.SSSZ"/>
</tstamp>
- <condition property="asm.jar"
value="${nbplatform.active.dir}/platform/core/asm-all-5.0.1.jar">
- <available
file="${nbplatform.active.dir}/platform/core/asm-all-5.0.1.jar"/>
+ <condition property="asm.jar"
value="${nbplatform.active.dir}/platform/core/asm-7.0.jar">
+ <available
file="${nbplatform.active.dir}/platform/core/asm-7.0.jar"/>
</condition>
- <property name="asm.jar"
location="${platform/libs.asm.dir}/core/asm-all-5.0.1.jar"/>
+ <property name="asm.jar"
location="${platform/libs.asm.dir}/core/asm-7.0.jar"/>
Review comment:
If I'm reading this correctly this is only used for java html integration
@jtulach implemented. It would be good if @jtulach would check, what from asm
is needed to satisfy the requirements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists