sdedic commented on a change in pull request #1108: Upgraded ASM libraries to
7.0
URL:
https://github.com/apache/incubator-netbeans/pull/1108#discussion_r254718803
##########
File path: java/lib.jshell.agent/nbproject/project.properties
##########
@@ -21,5 +21,5 @@ javac.compilerargs=-Xlint -Xlint:-serial
extra.module.files=modules/ext/nb-custom-jshell-probe.jar,modules/ext/nb-mod-jshell-probe.jar
jnlp.indirect.jars=modules/ext/nb-custom-jshell-probe.jar,modules/ext/nb-mod-jshell-probe.jar
-agentsrc.asm.cp=${libs.asm.dir}/core/asm-all-5.0.1.jar
+agentsrc.asm.cp=${libs.asm.dir}/core/asm-7.0.jar
Review comment:
Yes, the agent needs all dependencies in its JAR, or on bootstrap classpath.
I am afraid that cutting down the bundled library size would be painful: the
ASM is actually used to inject `<classinit>` into user code so that the agent
gets a reference to a `ClassLoader` that loaded the particular class of
interest. Since I need to inspect the class contents and actually generate
bytecode, most of the packages are IMHO used; maybe we can save `tree.analysis`.
The classloader can be later reach the class by name. This is useful for
more arcane environments with custom classloaders (e.g. NetBeans itself ;))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
