JaroslavTulach commented on a change in pull request #1135: [NETBEANS-1979]
Create Mode from client code
URL:
https://github.com/apache/incubator-netbeans/pull/1135#discussion_r258983607
##########
File path:
platform/core.windows/src/org/netbeans/core/windows/persistence/PersistenceManager.java
##########
@@ -1364,6 +1363,16 @@ public static String escapeTcId4XmlContent (String
tcName) {
}
return tcName;
}
+
+ public ModeConfig createModeFromXml(String xml) throws IOException {
+ ModeParser modeParser = ModeParser.parseFromString("NO_NAME_YET", new
HashSet(1));
Review comment:
We used to add `// NOI18N` to mark strings that shouldn't be translated.
Having them in some `static final String` constant would be even better,
especially when used sever times.
`new HashSet(1)` seems strange. Such size cannot even access a single
element (as the ratio is `0.75` by default and `1 * 0.75 < 1`), is that what
you wanted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
