matthiasblaesing commented on issue #1143: [NETBEANS-1995] Exclude extra cluster when generating LICENSE file URL: https://github.com/apache/incubator-netbeans/pull/1143#issuecomment-466160642 Thank you for the pointer and explanation Jaroslav, that helped me to understand. Maybe this could be considered as an enhancement to the change: ```diff --- a/nbbuild/build.xml +++ b/nbbuild/build.xml @@ -79,6 +79,12 @@ <include name="platform/javahelp/external/binaries-list"/> </manifest> </downloadbinaries> + <!-- + nb-extra-files denotes directories/files, that are not packed for + distribution. The clusters are only used for local development/testing. + The files must not be included in distribution zip and also need to be + excluded from license analysis + --> <property name="nb-extra-files" value="test/**,extra/**"/> <echo message="Bootstrapping NetBeans-specific Ant extensions..."/> ``` Though either way, for a license perspective this looks good to me (I did a build and checked the LICENSE file of the result zip). However, I don't see that it works. I used the above mentioned zip, extracted it and run it with a clean user+cache dir. I would now expect the "Embedded Browser UI - JavaFX WebView" plugin to be activeable (requirering me to install javafx), but this is not the case. I don't see an option to install JavaFX as a plugin. What am I missing?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
