matthiasblaesing commented on issue #1207: Performance Save Patch - Replace 
replaceAll() with replace()
URL: https://github.com/apache/netbeans/pull/1207#issuecomment-489451040
 
 
   You'll need to update your approach and/or scanning technology. One example 
from your file:
   
   filename = filename.replaceAll("Controller$", "");
   
   You claim:
   
   > these 117 use string literals in both replaceAll() parameters and use no 
form of regex.
   
   That claim is wrong. The above sample contains an end-of-line matcher, so 
that is a valid regular expression and could not be replaced with 
String#replace.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to