svatoun commented on issue #1232: [NETBEANS-2437] Unit tests of php.editor fail URL: https://github.com/apache/netbeans/pull/1232#issuecomment-489521615 yes, my big mistake; I didn't notice the explicit reference to the removed jar (`/../libs.nashorn/external/nashorn-02f810c26ff9-patched.jar`). Should be replaced as shown in the diff, IMHO. The removal of `asm` is a good cleanup, since there's `asm-5.0.0` loaded by core; and there's no asm any more either from 2016 :) It would be awesome if the inclusion of oracle js parser could be added as **test** dependency into e.g. libs.nashorn, to have (some) JS parser ready for all js-dependent tests (with usage of `recursive` modifier).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
