matthiasblaesing commented on a change in pull request #1034: NETBEANS-1499 -
change package.json icon
URL: https://github.com/apache/netbeans/pull/1034#discussion_r281749292
##########
File path:
webcommon/javascript.nodejs/src/org/netbeans/modules/javascript/nodejs/resources/npm-resolver.xml
##########
@@ -26,4 +26,12 @@
<name name="package.json"/>
<resolver mime="text/package+x-json"/>
</file>
+ <file>
+ <name name="package-lock.json"/>
+ <resolver mime="text/package-lock+x-json"/>
+ </file>
+ <file>
+ <name name="npm-debug.log"/>
+ <resolver mime="text/plain"/>
Review comment:
This looks fishy. I understand, that you want to associate your new Editor
with only "npm-debug.log", yet you assign it the mimeType "text/plain". That
mimetype matches a big chunk of files on my harddisk, which you would all pull
through your special data object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
