jlahoda commented on a change in pull request #1207: Performance Save Patch -
Replace replaceAll() with replace()
URL: https://github.com/apache/netbeans/pull/1207#discussion_r282646839
##########
File path:
java/java.source.base/src/org/netbeans/modules/java/source/usages/ExecutableFilesIndex.java
##########
@@ -164,7 +164,7 @@ static String wrap(Set<String> values) {
attribute.append("::"); //NOI18N
}
s = s.replaceAll("\\\\", "\\\\\\\\"); //NOI18N
- s = s.replaceAll(":", "\\\\d"); //NOI18N
+ s = s.replace(":", "\\\\d"); //NOI18N
Review comment:
Hmmmm, the replacement string is *probably* not equivalent (I think it
should have 1/2 of the '\\', but please check).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
