jlahoda commented on a change in pull request #1245: [NETBEANS-2455]
splash-about screen generation
URL: https://github.com/apache/netbeans/pull/1245#discussion_r283119597
##########
File path: platform/core.startup/build.xml
##########
@@ -21,4 +21,14 @@
-->
<project name="platform/core.startup" default="build" basedir=".">
<import file="../../nbbuild/templates/projectized.xml"/>
+ <target name="build-init" depends="projectized.build-init">
+ <taskdef name="splash-screen"
classname="org.netbeans.nbbuild.assets.GenerateSplashScreenTask"
classpath="${nbantext.jar}" />
+ <echo message="Generating splash screens with build number ${buildnum}"
/>
+ <splash-screen
+ font='../../nbbuild/external/montserrat-medium.ttf'
+
output='src/org/netbeans/core/startup/splash.gif'>${buildnum}</splash-screen>
Review comment:
I wonder - is there a strong reason to generate the files into the source
directories? Wouldn't it work to generate them to '${build.classes.dir}' (may
require <mkdir dir="${build.classes.dir}"> as well)? That would keep the
sources clean, and would avoid the need to tweak .gitignore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
