rtaneja1 commented on a change in pull request #1237: [NETBEANS-2349] Convert
switch typecast case to switch expression
URL: https://github.com/apache/netbeans/pull/1237#discussion_r283242768
##########
File path:
java/java.hints/src/org/netbeans/modules/java/hints/errors/Utilities.java
##########
@@ -3265,16 +3277,34 @@ public Void visitIdentifier(IdentifierTree node, Void
p) {
}
}
}
- if (isReturnExpression) {
- ExpressionTree et = (ExpressionTree)
make.SwitchExpression(TreeShims.getExpressions(st).get(0), newCases);
- wc.rewrite(st, make.Return(et));
- } else if (isExpression) {
- ExpressionTree et = (ExpressionTree)
make.SwitchExpression(TreeShims.getExpressions(st).get(0), newCases);
- wc.rewrite(st, make.ExpressionStatement((ExpressionTree)
make.Assignment((ExpressionTree) variable, et)));
- } else if (switchExpressionFlag) {
- wc.rewrite(st,
make.SwitchExpression(TreeShims.getExpressions(st).get(0), newCases));
- } else {
- wc.rewrite((SwitchTree) st, make.Switch(((SwitchTree)
st).getExpression(), newCases));
+ ExpressionTree et = null;
+ switch(switchType){
+ case SIMPLIFIED_WITH_RETURN_CASE:
+ et = (ExpressionTree)
make.SwitchExpression(TreeShims.getExpressions(st).get(0), newCases);
+ if(typeCast != null){
+ et = make.Parenthesized(et);
+ et = make.TypeCast(typeCast, et);
+ }
+ wc.rewrite(st, make.Return(et));
+ break;
+ case SIMPLIFIED_WITH_CAST_CASE:
+ et = (ExpressionTree)
make.SwitchExpression(TreeShims.getExpressions(st).get(0), newCases);
Review comment:
typeCase null check required here as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
