matthiasblaesing commented on issue #1242:  [NETBEANS-2509] Bring back docker 
plugin support for unix sockets
URL: https://github.com/apache/netbeans/pull/1242#issuecomment-492783959
 
 
   This looks reasonably sane. Your test-failure is explainable, as I gave you 
the wrong filenames, sorry about that. Please move the license and notice to 
`junixsocket-2.2.0-license.txt`  and `junixsocket-2.2.0-notice.txt`. I'd also 
make the junixsocket library friend-only for now. That way we know which 
modules to check when we update the library. This can be done in the GUI 
(Project Properties -> API Versionioning -> `Export Packages only to Friends`. 
Or directly in the project.xml:
   
   ```xml
   <!-- ... -->
               <!-- Remove public-packages element -->
               <friend-packages>
                   <friend>org.netbeans.modules.docker.api</friend>
                   <package>org.newsclub.net.unix</package>
               </friend-packages>
   <!-- ... -->
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to