jlahoda commented on a change in pull request #1244: [NETBEANS-1936] Usage of
remainderDelimiter
URL: https://github.com/apache/netbeans/pull/1244#discussion_r284892197
##########
File path:
ide/subversion/src/org/netbeans/modules/subversion/client/cli/commands/VersionCommand.java
##########
@@ -84,7 +84,7 @@ public boolean checkForErrors() {
if (pos > -1) {
String vString = string.substring(pos + 9);
Subversion.LOG.log(Level.INFO, "Commandline client version:
{0}", vString);
- Version version = Version.parse(vString.replace("-dev", ""));
+ Version version = Version.parse(vString, "-");
Review comment:
I think I understand what you are trying to do, and that is fine.
But, your patch (appears to) break other usecases, specifically, parsing of
versions like:
svn, version 1.9.7 (r1800392)
And that is not fine, IMO. So I am afraid you'll need to find a way to parse
both/all the versions correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
