jglick commented on a change in pull request #1144: [NETBEANS-2284]:NB build
with jdk11
URL: https://github.com/apache/netbeans/pull/1144#discussion_r290374626
##########
File path: java/java.j2seplatform/build.xml
##########
@@ -25,7 +25,7 @@
<target name="probe" depends="init">
<mkdir dir="build/probe/classes"/>
- <javac srcdir="probesrc" destdir="build/probe/classes" source="1.3"
debug="true" deprecation="true" target="1.1"/>
+ <javac srcdir="probesrc" destdir="build/probe/classes"
source="${javac.source}" debug="true" deprecation="true"
target="${javac.target}"/>
Review comment:
This, for example, seems to have broken the probing functionality for JDK 7
and below, and unnecessarily: you could have just gone down to Java 6, breaking
it only for JDK 5 and below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
