eirikbakke commented on a change in pull request #1278: [NETBEANS-2604] Support SVG icon loading from ImageUtilities URL: https://github.com/apache/netbeans/pull/1278#discussion_r291580286
########## File path: platform/libs.batik/nbproject/project.properties ########## @@ -15,6 +15,22 @@ # specific language governing permissions and limitations # under the License. +file.reference.batik-anim-1.11.jar=external/batik-anim-1.11.jar +file.reference.batik-awt-util-1.11.jar=external/batik-awt-util-1.11.jar +file.reference.batik-bridge-1.11.jar=external/batik-bridge-1.11.jar +file.reference.batik-constants-1.11.jar=external/batik-constants-1.11.jar +file.reference.batik-css-1.11.jar=external/batik-css-1.11.jar +file.reference.batik-dom-1.11.jar=external/batik-dom-1.11.jar +file.reference.batik-ext-1.11.jar=external/batik-ext-1.11.jar +file.reference.batik-gvt-1.11.jar=external/batik-gvt-1.11.jar +file.reference.batik-i18n-1.11.jar=external/batik-i18n-1.11.jar +file.reference.batik-parser-1.11.jar=external/batik-parser-1.11.jar +file.reference.batik-script-1.11.jar=external/batik-script-1.11.jar +file.reference.batik-svg-dom-1.11.jar=external/batik-svg-dom-1.11.jar +file.reference.batik-util-1.11.jar=external/batik-util-1.11.jar +file.reference.batik-xml-1.11.jar=external/batik-xml-1.11.jar +file.reference.xml-apis-ext-1.3.04.jar=external/xml-apis-ext-1.3.04.jar +file.reference.xmlgraphics-commons-2.3.jar=external/xmlgraphics-commons-2.3.jar Review comment: The "optional module" approach is exactly what I intended to do here, but I don't think I did it quite right yet. That is one of my remaining questions. The intention was for the openide.util.ui.svg, and its dependency libs.batik, to be an optional implementation module that registers SVGLoaderImpl as an implementation of SVGLoader (via the ServiceProvider annotation). Then, only if said module is installed was ImageUtilities supposed to provide SVG support. And ImageUtilities would only load the module once an actual SVG file is encountered to load. But having now built the platform and tried my NetBeans Platform application with it, I see that I get SVG support even though I don't actually mention a dependency on the openide.util.ui.svg module anywhere. What's the right way to make the openide.util.ui.svg module, and related modules, optional for NetBeans Platform apps? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
