matthiasblaesing commented on issue #1278: [NETBEANS-2604] Support SVG icon loading from ImageUtilities URL: https://github.com/apache/netbeans/pull/1278#issuecomment-500226838 Am Donnerstag, den 06.06.2019, 15:38 -0700 schrieb Eirik Bakke: > As for SVG files, at least these particular ones, I prefer to regard > them as opaque files that shouldn't be hand-edited, since they will > be re-generated by Adobe Illustrator every time we make changes to > the icons. This raises the question whether Adobe Illustrator is the right tool. I don't know the ratio of people having access to Adobe Illustrator, but I would prefer tools directly working on the SVG code. If needed for example with pure SVG code, we could transform the files at build time and strip comments and so on. However, Apache is pretty clear, that files, that can carry the license header should (very hard should) carry it. For SVG files this is the case. If Adobe Illustrator is not able to add a fixed comment (apparantly it can, as there is already one), additional tooling needs to do it (adding an XML comment will not be hard). > (Besides, SVG icons, which are loaded at runtime, will become about > 25% larger on average if we add a license comment to each. Not sure > it really matters.) Depends - I tested the raw parsing speed (file -> DOM) and got a penalty of about 5% (undo.svg with and without comment). For transcoding to PNG I got a penalty of 4%. With caching this is a one- off problem. Seinng the SVG-PNG comparison, this speed problem looks not significant. The size itself IMHO is not problem - if it is, run the files through gzip and decompress von the fly. Am Samstag, den 08.06.2019, 20:41 -0700 schrieb Jaroslav Tulach: > > I'm curious which apps use the platform and would use a modern > > Apache NetBeans Platform > > version but wouldn't want to support HiDPI screens? > > ... we are talking about the NetBeans Runtime Container. People like > @jlahoda, @tzezula and @sdedic spent a significant amount of time > making sure NetBeans modules can be used in a headless mode. We are > not going to ruin such efforts just because we want SVG icons. That arguement does not cut it. There is net.java.html.* already in the platform. The same argument would cut there, as they are surely not running headless.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
