neilcsmith-net commented on a change in pull request #1411: build branding URL: https://github.com/apache/netbeans/pull/1411#discussion_r325261607
########## File path: nb/updatecenters/src/org/netbeans/modules/updatecenters/resources/Bundle.properties ########## @@ -28,12 +28,13 @@ Services/AutoupdateType/pluginportal-update-provider.instance=NetBeans Plugin Po Services/AutoupdateType/82pluginportal-update-provider.instance=NetBeans 8.2 Plugin Portal #NOI18N -URL_Distribution=https://netbeans.apache.org/nb/updates/dev/updates.xml.gz?{$netbeans.hash.code} +URL_Distribution=@@metabuild.DistributionURL@@{$netbeans.hash.code} Review comment: @ebarboni as per comment on the release json, should we remove `{$netbeans.hash.code}` here and manage from the json file? We at least seem to be missing a `?` to start the URL query? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
