neilcsmith-net commented on issue #1527: update path of gitinfo to be aside user.build.properties URL: https://github.com/apache/netbeans/pull/1527#issuecomment-534135039 @ebarboni I'm not sure this is exactly the right approach. If someone checks out the sources with git, they want that file to be generated in `nbbuild/build` only, surely? However, with the source zip, we want to provide the contents for that file for them. So, perhaps we should write that file as part of the source zip at `nbbuild/gitinfo.properties`. But the build should check if `nbbuild/gitinfo.properties` exists, and copy to `nbbuild/build/gitinfo.properties`. Then proceed as before - if `nbbuild/build/gitinfo.properties` doesn't exist, generate it. That way, the source zip works, and a git checkout remains in sync. Or am I missing something?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
