junichi11 commented on issue #1551: Module list to log missing code base URL: https://github.com/apache/netbeans/pull/1551#issuecomment-538766601 It seems that this PR includes incorrect merges. (not `apisupport.ant/src/org/netbeans/modules/apisupport/project/universe/ModuleList.java` but `apisupport/apisupport.ant/src/org/netbeans/modules/apisupport/project/universe/ModuleList.java`) You should sync your master branch with the master branch of apache/netbeans repo before you create a new branch for this pr. Please add the issue number to the commit title. Please read https://netbeans.apache.org/participate/submit-pr.html BTW, ```java public static String findText(Node parent) { if (parent == null) return null; ``` - Please add curly braces to the if statement - Please add `@CheckForNull` if `null` is returned - Please use 4 spaces instead of a TAB space e.g. ```java @CheckForNull public static String findText(Node parent) { if (parent == null) { return null; } ``` Maybe, you should create a new PR, then should close this. Thanks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists