oyarzun commented on issue #1411: build branding URL: https://github.com/apache/netbeans/pull/1411#issuecomment-541189327 @neilcsmith-net I saw that it should be coming from MainImpl.java. Is it from the ide branding module? The null is because it is expecting a date for the regex, e.g. 20190924, but we now use the git hash. This is the manifest from Beta2 ``` Manifest-Version: 1.0 Ant-Version: Apache Ant 1.10.6 Created-By: 1.8.0_191-b12 (Oracle Corporation) OpenIDE-Module-Public-Packages: - OpenIDE-Module-Java-Dependencies: Java > 1.6 OpenIDE-Module-Implementation-Version: 11.2-beta2-86e1b2eb194e8e9628a6 6e6ee1a128134c70671a AutoUpdate-Show-In-Client: false OpenIDE-Module: org.netbeans.modules.ide.branding/1 OpenIDE-Module-Layer: org/netbeans/modules/ide/branding/layer.xml OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/ide/branding/Bu ndle.properties OpenIDE-Module-Specification-Version: 1.38 OpenIDE-Module-Requires: org.openide.modules.ModuleFormat1 ``` and 11.1 ``` Manifest-Version: 1.0 Ant-Version: Apache Ant 1.9.7 Created-By: 1.8.0_131-b11 (Oracle Corporation) OpenIDE-Module-Public-Packages: - OpenIDE-Module-Java-Dependencies: Java > 1.6 OpenIDE-Module-Implementation-Version: netbeans-release-428-on-2019071 6 AutoUpdate-Show-In-Client: false OpenIDE-Module: org.netbeans.modules.ide.branding/1 OpenIDE-Module-Layer: org/netbeans/modules/ide/branding/layer.xml OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/ide/branding/Bu ndle.properties OpenIDE-Module-Specification-Version: 1.37 OpenIDE-Module-Requires: org.openide.modules.ModuleFormat1 ``` and 11.2 beta 1 ``` Manifest-Version: 1.0 Ant-Version: Apache Ant 1.10.6 Created-By: 1.8.0_191-b12 (Oracle Corporation) OpenIDE-Module-Public-Packages: - OpenIDE-Module-Java-Dependencies: Java > 1.6 OpenIDE-Module-Implementation-Version: netbeans-TLP/netbeans/release11 2-14-on-20190924 AutoUpdate-Show-In-Client: false OpenIDE-Module: org.netbeans.modules.ide.branding/1 OpenIDE-Module-Layer: org/netbeans/modules/ide/branding/layer.xml OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/ide/branding/Bu ndle.properties OpenIDE-Module-Specification-Version: 1.38 OpenIDE-Module-Requires: org.openide.modules.ModuleFormat1 ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists