matthiasblaesing commented on a change in pull request #1845: Adding
LICENSE/NOTICE for the VisualStudio Code extension for Java
URL: https://github.com/apache/netbeans/pull/1845#discussion_r363099402
##########
File path: java/java.lsp.server/build.xml
##########
@@ -51,4 +51,65 @@
<target name="clean" depends="projectized.clean">
<delete dir="${lsp.build.dir}" />
</target>
+ <target name="build-vscode-ext" depends="build-lsp-server"
description="Build the Visual Studio Code extension.">
+ <exec executable="npm" failonerror="true" dir="vscode">
+ <arg value="install" />
+ </exec>
+
+ <exec executable="npm" failonerror="true" dir="vscode">
+ <arg value="run" />
+ <arg value="compile" />
+ </exec>
+
+ <delete dir="${build.dir}/vscode" />
+ <exec executable="cp" failonerror="true">
+ <arg value="-r" />
+ <arg value="vscode/" />
+ <arg value="${build.dir}/" />
+ </exec>
+
+ <delete dir="${build.dir}/bundles" />
+ <mkdir dir="${build.dir}/bundles/package" />
+ <copy file="vscode/package.json" todir="${build.dir}/bundles/package"
/>
+
+ <exec executable="mvn" failonerror="true"
dir="${nb_all}/nbbuild/misc/prepare-bundles">
+ <arg value="install" />
Review comment:
Shouldn't package be enough? `exec:java` should use the build package from
target, not the one from the local repository.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
