mklaehn commented on a change in pull request #1872: [NETBEANS-3695] - not
proper to use a static variable through a refer…
URL: https://github.com/apache/netbeans/pull/1872#discussion_r367028572
##########
File path:
ide/team.commons/src/org/netbeans/modules/bugtracking/commons/LinkButton.java
##########
@@ -119,10 +119,10 @@ public LinkButton() {
}
public void setColors(Color linkColor, Color linkInFocusColor, Color
mouseOverLinkColor, Color visitedLinkColor) {
- this.linkInFocusColor = linkInFocusColor;
- this.linkColor = linkColor;
- this.mouseOverLinkColor = mouseOverLinkColor;
- this.visitedLinkColor = visitedLinkColor;
+ linkInFocusColor = linkInFocusColor;
+ linkColor = linkColor;
+ mouseOverLinkColor = mouseOverLinkColor;
+ visitedLinkColor = visitedLinkColor;
Review comment:
Short answer something like `LinkButton.linkInFocusColor = linkInFocusColor`
for these four.
Long answer: If you simply remove the `this.` you essentially assign the
method parameter to itself. Highlighting in NetBeans Editor will show that as
well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
