lahodaj commented on a change in pull request #1877: [NETBEANS-3604]Supports
for Records (JEP 359) in JDK-14"
URL: https://github.com/apache/netbeans/pull/1877#discussion_r367891641
##########
File path:
java/java.editor.base/test/unit/src/org/netbeans/modules/java/editor/base/semantic/DetectorTest.java
##########
@@ -508,6 +508,62 @@ public void testIncDecReading230408() throws Exception {
performTest("IncDecReading230408");
}
+ public void testRecord1() throws Exception {
+ //TODO: check records are available, skip if they are not.
Review comment:
There should be a SourceVersion check, or something along those lines, and
the test case should be skipped if the current javac does not support records.
Otherwise, the test will fail when running e.g. with nb-javac without records.
(Dtto the other occurrence below.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
