matthiasblaesing commented on issue #1034: NETBEANS-1499 - change package.json icon URL: https://github.com/apache/netbeans/pull/1034#issuecomment-576043269 I looked at the mime registration again today and while reading about this, I noticed, that the mimetypes should have been different: - `text/package+x-json` should have been `application/x.npm-package+json` - `text/package-lock+x-json` should have been `application/x.npm-package-lock+json` - `text/npm-log` should have been `text/x.npm-log+plain` Reasoning: The mimetypes are unregistered (thus the `x.` for the subtype) but they are all based on existing types. For former two are based on `application/json` and the latter is based on `text/plain`. The `+json` parts are the suffix to designate their base type. Its to late now, but should be considered next time.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
