mario-s commented on a change in pull request #1886: Update to Groovy 2.5.9 and
enable groovy editor tests
URL: https://github.com/apache/netbeans/pull/1886#discussion_r368564006
##########
File path:
groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/completion/inference/TypeInferenceVisitor.java
##########
@@ -194,4 +193,29 @@ private static boolean sameVariableName(ASTNode node1,
FieldNode node2) {
&& ((VariableExpression)
node1).getName().equals(node2.getName());
}
+ private ClassNode deriveExpressonType(Expression expression) {
Review comment:
What about a single return statement here? IMHO those are too many. It's
also a bit inconsistent with the previous method (visitDeclarationExpression).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
