matthiasblaesing commented on issue #1948: Simple linux notifications integration module URL: https://github.com/apache/netbeans/pull/1948#issuecomment-586609387 Should this be discussed first? I.e. not just a PR, but a discussion on the mailing list? GUI changes have the tendency to introduce bikeshedding and in this case the question why implementations for windows/mac OS are not done will come up quickly. I assume this is a base for discussion as the finer parts of the api (action listener, balloon detail, priority) are currently uncovered. For the libnotify bindings: Is the native encoding of the java platform the right encoding? Or does it need to be UTF-8 or something like that? By default JNA maps strings to (C) char by using the default platform encoding. Personal comment: For me I don't like the Optional style programming here. Maybe I'm getting old, but simple null checks look much more straight forward and are IMHO more readable.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
