matthiasblaesing commented on a change in pull request #2001: Get a file of all
libraries during download
URL: https://github.com/apache/netbeans/pull/2001#discussion_r389026132
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/DownloadBinaries.java
##########
@@ -161,6 +169,13 @@ public void execute() throws BuildException {
} else {
success &= fillInFile(hashAndFile[0],
hashAndFile[1], manifest, () -> legacyDownload(hashAndFile[0] + "-" +
hashAndFile[1]));
}
+ if (report != null) {
+ Files.write(
+ report.toPath(),
+ (hashAndFile[0] + ";" + hashAndFile[1]
+ ";" + include + "\n").getBytes(),
Review comment:
Please use the `getBytes(Charset)` variant. Depending on the default file
encoding can lead to bugs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
