jmborer commented on pull request #8: URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/8#issuecomment-620107099
> Thanks for the hint. i ran checkstyle now and fixed all introduced whitespace remarks introduced by the code change. > Checkstyle issues on master: 165 > Checkstyle issues on this pull request 166 > > The only one checkstyle issue left is the scope introduced to avoid polluting the parent scope with temporary variables. This scope can easily be removed if deemed unnecessary. For Maven plugins you must use the coding convention defined https://maven.apache.org/developers/conventions/code.html What IDE are you using, because coding conventions can be greatly simplified by using IDE formatting engines? For IntelliJ and Eclipse, you can find the profiles on the link above. For Netbeans, I have published my own profile here https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/files/4540018/java-maven-coding-style.zip ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
