codingfred commented on pull request #8: URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/8#issuecomment-620614846
@jmborer I took a look but the code still looks good. However I personally think it would be cleaner to rervert the merge of the master into this branch and instead rebase this branch onto the current master. With the rebase (and fixing any conflicts that may occur) the changes that this branch introduces are easier to review. Anyways as I said i could not observe any functional change so it should be good to go. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
