mgraciano commented on pull request #2119: URL: https://github.com/apache/netbeans/pull/2119#issuecomment-633305617
> I only had a quick look at this, but this is my reply: The code looks ok to merge, as long as the statements are true. The license header says, that the code is licensed to the ASF under contributor agreement, that means that @mgraciano needs to be in a position to do this, i.e. @mgraciano needs to be the sole author or contributions were so minimal, that they don't form a copyright on their own. If that is the case all is good, if not, the offending parts need to be removed. > > I saw at least one binary (auto_save.png) for which license information is missing. Please add a `licenseinfo.xml` file to add that info (for an example see `ide/db.dataview/licenseinfo.xml` and https://cwiki.apache.org/confluence/display/NETBEANS/Legal+FAQ#LegalFAQ-licenseinfoPerfileinfo-licenseinfo.xml) > > For the code itself: While unifying the translations is important, I would not see it as a breaking problem, as it can be fixed after integration. After the integration I can continue to do the fixes as necessary, even the translation. I intend to create some testes too in the future. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
