KacerCZ commented on a change in pull request #2149:
URL: https://github.com/apache/netbeans/pull/2149#discussion_r429873439
##########
File path:
php/php.code.analysis/src/org/netbeans/modules/php/analysis/options/AnalysisOptionsValidator.java
##########
@@ -73,7 +73,7 @@ public AnalysisOptionsValidator
validateCodeSnifferPath(String codeSnifferPath)
@NbBundle.Messages("AnalysisOptionsValidator.codeSniffer.standard.empty=Valid
code sniffer standard must be set.")
public AnalysisOptionsValidator validateCodeSnifferStandard(String
codeSnifferStandard) {
Review comment:
Yes, now its used at more places.
Personally I would removed this method and all its usages, because I don't
see any value testing if standard is not null. There are places where null is
replaced by empty string.
##########
File path:
php/php.code.analysis/src/org/netbeans/modules/php/analysis/options/AnalysisOptionsValidator.java
##########
@@ -73,7 +73,7 @@ public AnalysisOptionsValidator
validateCodeSnifferPath(String codeSnifferPath)
@NbBundle.Messages("AnalysisOptionsValidator.codeSniffer.standard.empty=Valid
code sniffer standard must be set.")
public AnalysisOptionsValidator validateCodeSnifferStandard(String
codeSnifferStandard) {
Review comment:
Yes, now its used at more places.
Pesonally I would removed this method and all its usages, because I don't
see any value testing if standard is not null as in other places null value is
replaced by empty string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
