arusinha commented on a change in pull request #2015:
URL: https://github.com/apache/netbeans/pull/2015#discussion_r431398873



##########
File path: nbi/engine/build.xml
##########
@@ -20,10 +20,17 @@
 
 -->
 
-<project name="NBI_Engine" default="default" basedir=".">
+<project name="nbi/engine" default="default" basedir=".">

Review comment:
       @oyarzun , separate NB installer is released each for Linux/Mac/Windows. 
 
   Conditional import can come handy.
   Possible solution can be 
   <property name="IS_NB_INSTALLER" value="true" />(this property has to be 
defined in installer/infra/build/build.xml)
   nbi/engine/build.xml  changes
   <condition property="relative_path" value="../../../../" else="../../">
    <isset property="IS_NB_INSTALLER"/>
           </condition>
               <import 
file="${relative_path}/nbbuild/templates/projectized.xml"/>




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to