JaroslavTulach commented on a change in pull request #2192:
URL: https://github.com/apache/netbeans/pull/2192#discussion_r443390287
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ConfigureProxy.java
##########
@@ -57,6 +55,17 @@ public void setPortProperty(String port) {
@Override
public void execute() throws BuildException {
+ log("Proxy configuration", Project.MSG_INFO);
+
+ // Prevent proxy configuration on CI environments (Travis, GitHub
actions)
+ String isCIEnvironment = System.getenv("CI");
Review comment:
This is not correct check in my opinion and once the `configureproxy` is
idenpotent - e.g. #2210, you will not need this check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
