jlahoda commented on pull request #2224:
URL: https://github.com/apache/netbeans/pull/2224#issuecomment-652783275
Hi Adam,
Thanks for the fix!
I have two suggestions:
-RECORD should probably be added to TreeUtilities.CLASS_TREE_KINDS directly,
rather than check for it on usages. (Should be doable using
Tree.Kind.valueOf("RECORD"), catching the IllegalArgumentException, if the kind
does not exist.)
-it would be awesome if some tests could be updated, existing tests are e.g.:
https://github.com/apache/netbeans/blob/21e19a3f60e69935f7cfe5ff5b0110346bcd8aaf/java/java.editor.base/test/unit/src/org/netbeans/modules/java/editor/base/semantic/DetectorTest.java#L539
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
