BradWalker commented on a change in pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114#discussion_r449985353
##########
File path:
java/maven.grammar/src/org/netbeans/modules/maven/codegen/ExclusionGenerator.java
##########
@@ -90,9 +90,9 @@ public int write() {
// now check the active profiles for the
dependency..
List<String> profileNames = new
ArrayList<String>();
NbMavenProject project =
prj.getLookup().lookup(NbMavenProject.class);
- Iterator it =
project.getMavenProject().getActiveProfiles().iterator();
+ Iterator<org.apache.maven.model.Profile> it =
project.getMavenProject().getActiveProfiles().iterator();
Review comment:
Hey @hectorespert , I wish I could do this.. But, there is already
another Profile class being used, org.netbeans.modules.maven.model.pom.Profile.
And it's not easy to distinguish between the two..
So we're going to have to leave this one alone..
Thanks for the feedback and hopefully you can now approve it for 12.1..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
