lahodaj commented on a change in pull request #2222:
URL: https://github.com/apache/netbeans/pull/2222#discussion_r460728527
##########
File path:
java/java.completion/test/unit/data/goldenfiles/org/netbeans/modules/java/completion/JavaCompletionTaskTest/10/override.pass
##########
@@ -0,0 +1 @@
+Override
Review comment:
I don't think we need the golden files that are the same for 1.8 and 10
and other versions, right? If the tests don't find the golden output for e.g.
version 10, they should look for the golden output of older versions. I.e. it
should be enough to specify a golden output for 1.8, and only re-specify it if
it changes in a newer version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
