matthiasblaesing edited a comment on pull request #2302: URL: https://github.com/apache/netbeans/pull/2302#issuecomment-671031730
@neilcsmith-net I dropped the jakartaee change from this PR as it is better covered in #2272 as you pointed out. The initial build failure of the nbjavac library issue was caused by a dangeling reference in the manifest to the layer file I removed, this was fixed. Both remamaining commits are reviewed. Unittests are green. Ok to merge for 12.1? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
