JaroslavTulach commented on pull request #2232: URL: https://github.com/apache/netbeans/pull/2232#issuecomment-671159898
> Do we really need this in 12.1? No, I just wanted to reward Tim for polishing his PR. Up to you, as release coordinator, to decide. The integration of this PR shall be safe. Only when we try to [use of the new API](https://github.com/timboudreau/incubator-netbeans/tree/proxy-lookup-factory-methods-impl) we can get failures. That [branch](https://github.com/timboudreau/incubator-netbeans/tree/proxy-lookup-factory-methods-impl) is clearly for post 12.1. > Is the API documentation correct? It wasn't. I've done some necessary and some unnecessary changes in 316acb3 and 9e2f30f ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
