JaroslavTulach commented on pull request #2309: URL: https://github.com/apache/netbeans/pull/2309#issuecomment-675842962
> @JaroslavTulach OK. Are you not following dev@? I am sorry, I didn't read dev@ recently. I was completely focused on VSCode and elsewhere. Once all this PR checks got green, I integrated without realizing the master is supposed to be frozen. I should be more careful. This is a second time I made such mistake, I should learn my lesson. Possibly I was influenced by considering my change just a _robustness fix_ that cannot break anything. Running the diff and eliminating all VSCode specific changes: ```bash $ curl 'https://patch-diff.githubusercontent.com/raw/apache/netbeans/pull/2309.diff' \ | grep ^diff | grep -v java/java.lsp.server | grep -v nbbuild/misc/prepare-bundles \ | cut -f3 -d " " a/ide/spi.debugger.ui/src/org/netbeans/modules/debugger/ui/DebuggerManagerListener.java a/java/debugger.jpda.truffle/manifest.mf a/java/debugger.jpda.truffle/nbproject/project.xml a/java/maven/src/org/netbeans/modules/maven/api/execute/RunUtils.java a/java/maven/src/org/netbeans/modules/maven/execute/cmd/ExecutionEventObject.java a/nbbuild/build.xml a/platform/core.windows/src/org/netbeans/core/windows/services/DialogDisplayerImpl.java ``` leaves us with `isHeadless()` checks: * [ide/spi.debugger.ui](https://github.com/apache/netbeans/pull/2309/files#diff-b9c79046b9548364065efd8dd282089d) * [maven](https://github.com/apache/netbeans/pull/2309/files#diff-f038edf85db71cd67a5b2a356647847d) * [core.windows](https://github.com/apache/netbeans/pull/2309/files#diff-6aff1792e1913ea7946414fd9420635b) these checks shall not influence the release as NetBeans IDE isn't running in headless mode. Then there is another robustness check: * [IOFolding.isSupported](https://github.com/apache/netbeans/pull/2309/files#diff-0fc693f406ad5eae6e15b6063d7bdba0) it shall not influence NetBeans IDE as NetBeans IDE is using `core.output2` implementation of output window which supports folding. One more robustness check is done in buildsystem: * [check Packages](https://github.com/apache/netbeans/pull/2309/files#diff-fa67ba03971f6d21c0ff2493bf5d922f) that only fixes problem of running `ant tryme` on GraalVM, other JVMs continue to behave the same. And then there is the change of dependencies in `debugger.jpda.truffle` module which replaces strict dependency on `java.kit` with a recommendation. That's the only change that changes some behavior in the NetBeans IDE - however as the `java.kit` is present in the NetBeans IDE the change shall be idempotent. With the robustness fixes in master my [debugging in VSCode branch](https://github.com/apache/netbeans/compare/master...JaroslavTulach:java-lsp-server-debugging-attempt2) is much cleaner. Nice, but poor excuse for the organizational problems my integration causes just before release of 12.1. Once again, please accept my apology. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
