JaroslavTulach commented on a change in pull request #2317:
URL: https://github.com/apache/netbeans/pull/2317#discussion_r481637617
##########
File path:
platform/autoupdate.services/libsrc/org/netbeans/updater/ModuleUpdater.java
##########
@@ -579,6 +579,34 @@ private boolean unpack200(File src, File dest) {
return result == 0;
}
+ private File findUnpack200Executable(String unpack200) {
+ File unpack200Executable = new File(new
File(System.getProperty("java.home"), "bin"), unpack200);
+ if (!unpack200Executable.canExecute()) {
+ for (File clusterRoot : UpdateTracking.clusters(true)) {
+ File uiConfig = new File(new File(new File(new File(new
File(new File(new File(
+ clusterRoot, "config"), "Preferences"), "org"),
"netbeans"), "modules"), // NOI18N
+ "autoupdate"), "services.properties"); // NOI18N
Review comment:
Does that work on Windows and other systems? `new File(new File(...` is
portable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
