jtulach commented on a change in pull request #2317:
URL: https://github.com/apache/netbeans/pull/2317#discussion_r485310363
##########
File path:
platform/autoupdate.services/src/org/netbeans/modules/autoupdate/services/Utilities.java
##########
@@ -289,13 +289,15 @@ private static int mapVerificationResultToInt(String
input) {
* Get the certpaths that were used to sign the NBM content.
*
* @param nbmFile
+ * @param pack200Entries list of strings to add any entries in the NBM file
+ * that end with {@code .pack.gz} extension and may require pack200 tool
* @return collection of CodeSigners, that were used to sign the
non-signature
* entries of the NBM
* @throws IOException
* @throws SecurityException if JAR was tampered with or if the certificate
* chains are not consistent
*/
- public static Collection<CodeSigner> getNbmCertificates (File nbmFile)
throws IOException, SecurityException {
+ public static Collection<CodeSigner> getNbmCertificates (File nbmFile,
List<String> pack200Entries) throws IOException, SecurityException {
Review comment:
Reverted back to original signature in 80a6d71
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
