JaroslavTulach commented on a change in pull request #2337:
URL: https://github.com/apache/netbeans/pull/2337#discussion_r487387965
##########
File path: platform/applemenu/nbproject/project.xml
##########
@@ -104,7 +104,9 @@
</run-dependency>
</dependency>
</module-dependencies>
- <public-packages/>
+ <public-packages>
+ <package>org.netbeans.modules.applemenu.spi</package>
Review comment:
This is an API change and as such it should be documented with
`arch.xml`, `apichanges.xml` and addition of this module to list of Javadocs.
Or turn this into `friend-packages`. I don't like usage of friend packages
much but in this case, it is probably fine as nobody is likely to provide other
implementation anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
